feat: allow update of enrollment access for approved enrollments #1562

srieteja · 2023-09-14T08:52:44Z

- closes #1499

- What I did

allow update of enrollment access of approved enrollments for specific namespaces
refactor enroll verb handler
replace exceptions with appropriate error codes and error messages
Introduce new class EnrollmentResponse to handle responses and data in EnrollVerbHandler
add enrollment status of each enrollment to enroll:list response

- How I did it

Introduce a new apkam operation called update
an update request needs to be placed for an already existing enrollments with updated namespaces
an apkam authenticated connection needs to approve that request

- How to verify it

new unit and functional tests added to verify enrollment access update behaviour
existing tests modified to match refactoring

- Description for the changelog

feat: allow update of enrollment access for approved enrollments

# Conflicts: # packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart

packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart

…r message

…tests

packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart

…oded Response'

…ume the same in tests

…access_test

packages/at_secondary_server/pubspec.yaml

…w CustomInboundConnection class for tests

…e_enroll_access

sitaram-kalluri · 2023-11-21T02:24:00Z

The update enrollment feature is obsolete. Please refer to the git issue : #1499. Hence closing this issue.

srieteja added 2 commits September 14, 2023 14:07

feat: introduce new key format for supplementary enrollments

5bfc76a

feat: allow update of approved enrollments

e28ee6b

srieteja requested review from murali-shris and sitaram-kalluri September 14, 2023 08:52

srieteja marked this pull request as draft September 14, 2023 08:52

srieteja added 2 commits September 14, 2023 14:25

Merge branch 'trunk' into update_enroll_access

51a918f

# Conflicts: # packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart

fix: merge conflicts

08aaf5e

srieteja self-assigned this Sep 14, 2023

murali-shris requested changes Sep 14, 2023

View reviewed changes

sitaram-kalluri requested changes Sep 14, 2023

View reviewed changes

packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved

srieteja added 5 commits September 22, 2023 05:33

reformat: refactor enroll verb handler

6cd81fa

test: introduce tests for enrollment access update

26d4f1c

build: introduce at_commons dependency override

67e36ea

Merge branch 'trunk' into update_enroll_access

206b85b

fix: incorrect at_commons branch name

758c4a7

srieteja marked this pull request as ready for review September 22, 2023 00:25

srieteja added 6 commits September 24, 2023 00:23

test: fix unit tests

a0317eb

test: fix functional tests

9edc446

fix: base response handler now includes error description in the erro…

29668db

…r message

fix: base response handler responds with a jsonEncoded Response

9fab5e5

fix: consume base response handler changes in enroll_verb functional …

cc25bd3

…tests

fix: functional tests failing

f4de86c

sitaram-kalluri requested changes Sep 25, 2023

View reviewed changes

packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved

packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved

srieteja added 7 commits September 25, 2023 16:08

Merge branch 'trunk' into update_enroll_access

e224986

revert: commit 9fab5e5 'base response handler responds with a jsonEnc…

9be4455

…oded Response'

feat: optimize error/exception handling in EnrollVerbHandler and cons…

ae50538

…ume the same in tests

feat: optimize error/exception handling in EnrollVerbHandler and cons…

d31a81c

…ume the same in tests

tests: add enrollment test for enrollment access being updated

f2061c8

tests: add some more unit tests

27eb963

refactoring: EnrollVerbHandler refactoring to improve readability

0ce4cf3

srieteja and others added 6 commits October 3, 2023 04:47

docs: update exception messages and tests to match the change

78bb276

test: add some more functional tests

61d50e2

test: fix the failing functional tests

e422f35

test: improve assertions in functional tests

aa514f9

test: use llookup:key instead of scan.contains() in enroll_namespace_…

2bde0d3

…access_test

Merge branch 'trunk' into update_enroll_access

c9d1197

srieteja requested a review from sitaram-kalluri October 3, 2023 22:32

sitaram-kalluri reviewed Oct 4, 2023

View reviewed changes

packages/at_secondary_server/pubspec.yaml Outdated Show resolved Hide resolved

srieteja and others added 18 commits October 4, 2023 20:46

Merge branch 'trunk' into update_enroll_access

bf40bab

replace at_commons dep_override with latest released version

a8fabe0

fix: revert change made to DummyInboundConnection. Move changes to ne…

f46cf5c

…w CustomInboundConnection class for tests

Merge remote-tracking branch 'origin/update_enroll_access' into updat…

4aec00b

…e_enroll_access

Merge branch 'trunk' into update_enroll_access

9704e2b

fix: some more changes to improve readability

a8d5dd8

Merge branch 'trunk' into update_enroll_access

985e1a2

Merge branch 'trunk' into update_enroll_access

55e4b48

fix: some more changes to improve readability - 2

a449681

test: update functional tests with new code modifications

3e27c1b

test: update unit tests with new code modifications

5e638e4

test: rename few methods

cd6612a

Merge branch 'trunk' into update_enroll_access

274c8d5

tests: cram authentication is now part of prepare() in func_tests

5e4a6a3

tests: attempt to fix failing func_tests

c2e3e38

Merge remote-tracking branch 'origin/update_enroll_access' into updat…

1404f2c

…e_enroll_access

fix: isRequestAllowed() should only be checked for enroll:request

bed6c9d

tests: introduce teardowns for required test files

a310fcb

murali-shris approved these changes Nov 20, 2023

View reviewed changes

sitaram-kalluri closed this Nov 21, 2023

sitaram-kalluri deleted the update_enroll_access branch November 21, 2023 02:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow update of enrollment access for approved enrollments #1562

feat: allow update of enrollment access for approved enrollments #1562

srieteja commented Sep 14, 2023 •

edited

Loading

sitaram-kalluri commented Nov 21, 2023

feat: allow update of enrollment access for approved enrollments #1562

feat: allow update of enrollment access for approved enrollments #1562

Conversation

srieteja commented Sep 14, 2023 • edited Loading

sitaram-kalluri commented Nov 21, 2023

srieteja commented Sep 14, 2023 •

edited

Loading