test: removed unused at_end2end_test/test/commons.dart

chore: removed a TODO
atsign-foundation · Dec 12, 2024 · 810578e · 810578e
1 parent 84419de
commit 810578e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 126 deletions.
diff --git a/tests/at_end2end_test/test/commons.dart b/tests/at_end2end_test/test/commons.dart
diff --git a/tests/at_end2end_test/test/e2e_test_utils.dart b/tests/at_end2end_test/test/e2e_test_utils.dart
@@ -28,10 +28,17 @@ Future<SimpleOutboundSocketHandler> getSocketHandler(atSign) async {
   if (asc == null) {
     throw _NoSuchAtSignException('$atSign not configured');
   }
-  // TODO switch on _AtSignConfig.connectionType and create a
-  // TODO SimpleOutboundSocketConnection or SimpleOutboundWebsocketConnection
-  // TODO as required
-  var handler = SimpleOutboundSocketHandler._(asc.host, asc.port, atSign);
+
+  // ignore: prefer_typing_uninitialized_variables
+  var handler;
+  switch(asc.connectionType!) {
+    case _ConnectionTypeEnum.socket:
+      handler = SimpleOutboundSocketHandler._(asc.host, asc.port, atSign);
+      break;
+    case _ConnectionTypeEnum.websocket:
+      // TODO e.g. handler = SimpleOutboundWebsocketConnection._(asc.host, asc.port, atSign);
+      throw UnimplementedError('e2e_test_utils cannot yet create a websocket connection');
+  }
 
   await handler.connect();
   handler.startListening();
@@ -212,11 +219,11 @@ class _AtSignConfig {
   String atSign;
   String host;
   int port;
-  _ConnectionTypeEnum connectionType;
+  _ConnectionTypeEnum? connectionType;
 
   /// Creates and adds to [atSignConfigMap] or throws [_AtSignAlreadyAddedException] if we've already got it.
   _AtSignConfig(this.atSign, this.host, this.port, this.connectionType) {
-    this.connectionType ??= _ConnectionTypeEnum.socket;
+    connectionType ??= _ConnectionTypeEnum.socket;
     if (atSignConfigMap.containsKey(atSign)) {
       throw _AtSignAlreadyAddedException("AtSignConfig for $atSign has already been created");
     }

diff --git a/tests/at_end2end_test/test/update_verb_test.dart b/tests/at_end2end_test/test/update_verb_test.dart
@@ -3,7 +3,6 @@ import 'dart:math';
 
 import 'package:test/test.dart';
 
-import 'commons.dart';
 import 'e2e_test_utils.dart' as e2e;
 
 void main() {
@@ -77,6 +76,8 @@ void main() {
     expect(response, contains('data:$value'));
 
     //LOOKUP VERB in the other secondary
+    var maxRetryCount = 10;
+    var retryCount = 1;
     while (true) {
       await sh2.writeCommand('llookup:cached:$atSign_2:youtube_id$atSign_1');
       response = await sh2.read();