Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added rsa4096 and ed25519 implementation #749

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

feat: added rsa4096 and ed25519 implementation #749

wants to merge 3 commits into from

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Jan 8, 2025 •
edited
Loading

- What I did

  • Added impl for RSA 4096 and ed25519 in at_chops
    - How I did it
  • Changed return type in AtSigningAlgorithm methods to FutureOr. So this change will force a major release
  • Added ed25519 impl from better_crypto package
  • Added unit tests
    - How to verify it
  • tests should pass

Merge this PR and #744.
Run tests against trunk branch of at_chops with at_client and at_server. Publish at_chops major version

@murali-shris murali-shris marked this pull request as ready for review January 9, 2025 05:02
XavierChanth
XavierChanth requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@XavierChanth XavierChanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one typo that needs to be fixed

packages/at_chops/lib/src/algorithm/ed25519_signing_algo.dart
final _algorithm = Ed25519();
SimpleKeyPair? _ed25519KeyPair;

set edd25519KeyPair(SimpleKeyPair value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, should be ed not edd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth requested changes

@gkc gkc Awaiting requested review from gkc

@TylerTrott TylerTrott Awaiting requested review from TylerTrott

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murali-shris @XavierChanth