Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: standardAtClientStoragePath #698

Merged
merged 5 commits into from
Oct 22, 2024
Merged

fix: standardAtClientStoragePath #698

merged 5 commits into from
Oct 22, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Oct 22, 2024 •
edited
Loading

- What I did

  • fix standardAtClientStoragePath
  • test: add some basic tests of at_cli_commons utils.dart
  • build: add at_cli_commons to the matrix in the GH actions workflow

- How to verify it

  • tests pass
  • the build_and_test job is run for the at_cli_commons package

@gkc gkc requested a review from sitaram-kalluri October 22, 2024 10:49
@gkc gkc merged commit 159dbbb into trunk Oct 22, 2024
12 checks passed
@gkc gkc deleted the fix-standard-at-client-storage-path branch October 22, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitaram-kalluri sitaram-kalluri sitaram-kalluri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkc @sitaram-kalluri