-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce option to delete enrollment requests that are denied/revoked #670
Conversation
@srieteja @sitaram-kalluri Is this blocked by something? |
I was waiting for the server-side changes to be released. Server-side changes were released by @sitaram-kalluri last week. I will test this again and get it ready for review over the coming weekend. |
@srieteja You should stay focused on the C impl of at_activate. |
@gkc : Sure, I will pick this up. |
Tested the deletion of enrollment and works as expected. Attaching the test log: Deleting a revoked enrollment:
Deleting a denied enrollment:
|
@sitaram-kalluri Let's also wait to release this until this bug fix has been released |
@sitaram-kalluri I am going to merge this PR's changes into #682 since they are all related and I've made a number of changes in #682 related to the tests |
Sure, @gkc |
All of this PR's commits are now included in #682 |
Marked as draft since all of this PR's changes are now entirely included in #682 |
Closes #628
- What I did
- How I did it
- How to verify it