Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: at_cli_commons: handle malformed atsigns (no leading @) in CLIBase constructor #466

Merged
merged 4 commits into from
Dec 3, 2023

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Dec 1, 2023

- What I did
fix: handle malformed atsigns (no leading @) in CLIBase constructor

- How I did it
See commits

@gkc gkc requested a review from cconstab December 1, 2023 16:44
cconstab
cconstab previously approved these changes Dec 2, 2023
Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is atChops defaulted now hence the removal?

@gkc
Copy link
Contributor Author

gkc commented Dec 3, 2023

Is atChops defaulted now hence the removal?

@cconstab Yes deprecated in at_client 3.0.68 - but thanks for spotting that, I've now updated the pubspec also to require at_client ^3.0.68 ... can you re-review please?

@gkc gkc requested a review from cconstab December 3, 2023 12:37
@gkc gkc merged commit af5d9ad into trunk Dec 3, 2023
11 checks passed
@gkc gkc deleted the gkc/at_cli_commons/handle-malformatted-atsigns branch December 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants