Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modify the OTP syntax for client to set the expire duration #422

Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat: Modify the OTP syntax for client to set the expire duration #422

merged 3 commits into from
Oct 17, 2023

Conversation

sitaram-kalluri
Copy link
Member

- What I did

  • Enhance the OTP verb to carry TTL which represents the OTP expiry. This enables client to configure the OTP expirations.
  • Updated the version and changelog of at_commons.

- How I did it

  • Add "TTL" to the OTP verb regex.

- How to verify it

  • Updated the unit tests.

@sitaram-kalluri sitaram-kalluri mentioned this pull request Oct 9, 2023
Closed
gkc
gkc requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but cannot merge until atsign-foundation/at_server#1598 is complete

@sitaram-kalluri sitaram-kalluri requested a review from gkc October 17, 2023 08:51
gkc
gkc approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkc gkc merged commit 8aa8106 into trunk Oct 17, 2023
10 checks passed
@gkc gkc deleted the expire_otp_changes branch October 17, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@murali-shris murali-shris Awaiting requested review from murali-shris

@VJag VJag Awaiting requested review from VJag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitaram-kalluri @gkc