Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: at_directory_connection #10

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat: at_directory_connection #10

merged 2 commits into from
Jan 30, 2023

Conversation

JeremyTubongbanua
Copy link
Member

@JeremyTubongbanua JeremyTubongbanua commented Jan 26, 2023 •
edited
Loading

What I did

  • working at_root_connection

closes #4

@JeremyTubongbanua JeremyTubongbanua self-assigned this Jan 26, 2023
TylerTrott
TylerTrott requested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@TylerTrott TylerTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to leave the const char certificate hard coded? Thought it was supposed to be dynamic

@JeremyTubongbanua
Copy link
Member Author

Are we going to leave the const char certificate hard coded? Thought it was supposed to be dynamic

This is one of the things I will speak to Gary about

@TylerTrott
Copy link
Contributor

Are we going to leave the const char certificate hard coded? Thought it was supposed to be dynamic

This is one of the things I will speak to Gary about

Okay, do we wanna wait on this merge then?

@JeremyTubongbanua
Copy link
Member Author

Are we going to leave the const char certificate hard coded? Thought it was supposed to be dynamic

This is one of the things I will speak to Gary about

Okay, do we wanna wait on this merge then?

Merge for now (cause it works) and will refactor later. I will write a ticket on it

@JeremyTubongbanua
Copy link
Member Author

See #12

TylerTrott
TylerTrott approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@TylerTrott TylerTrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be updated

@TylerTrott TylerTrott merged commit 1464b4c into atsign-foundation:trunk Jan 30, 2023
@JeremyTubongbanua JeremyTubongbanua mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerTrott TylerTrott TylerTrott approved these changes

Assignees

@JeremyTubongbanua JeremyTubongbanua

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Talking to atDirectory
2 participants
@JeremyTubongbanua @TylerTrott