feat: Replace EncryptionUtil decryption methods with at_chops #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkc
reviewed
Jan 2, 2024
| throw AtPublicKeyChangeException( | ||
| 'Public key has changed. Cannot decrypt shared key ${atKey.toString()}', | ||
| intent: Intent.fetchEncryptionPublicKey, | ||
| exceptionScenario: ExceptionScenario.encryptionFailed); |
There was a problem hiding this comment.
Should be ExceptionScenario.decryptionFailed?
gkc
reviewed
Jan 2, 2024
| @@ -15,16 +15,16 @@ import 'package:at_chops/at_chops.dart'; | |||
| abstract class AbstractAtKeyEncryption implements AtKeyEncryption { | |||
| late final AtSignLogger _logger; | |||
| late String _sharedKey; | |||
| final AtClient _atClient; | |||
| final AtClient atClient; | |||
There was a problem hiding this comment.
why has the visibility been increased from _atClient to atClient?
There was a problem hiding this comment.
in LocalKeyDecryption i had call to super.atClient.
Modified the code in LocalKeyDecryption to remove call to super.atClient in latest commit
gkc
reviewed
Jan 2, 2024
| @@ -7,6 +7,8 @@ import 'package:encrypt/encrypt.dart'; | |||
| import 'package:crypto/crypto.dart'; | |||
| import 'package:at_utils/at_logger.dart'; | |||
|
|
|||
| //#TODO Replace calls to methods in this class with at_chops methods and | |||
| // move this class to test folder in next major release | |||
There was a problem hiding this comment.
Is it safe to mark this class and all of the methods as @Deprecated now?
There was a problem hiding this comment.
There are 4 sub tasks in #1145
this PR is for first sub task. I am currently working on second sub task.
Once all sub tasks are done, we can mark the methods deprecated
…atsign-foundation/at_client_sdk into replace_encryption_util_methods
gkc
approved these changes
Jan 3, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it