Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove useAtChops references in code #1142

Merged
merged 5 commits into from
Oct 20, 2023
Merged

feat: remove useAtChops references in code #1142

merged 5 commits into from
Oct 20, 2023

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Oct 16, 2023

- What I did

  • changes to enforce atClient to use atChops for authentication
  • remove the references to AtClientPreference.privateKey in tests
  • remove the use of EncryptionUtil in few classes which was used as fallback if useAtChops=false
    - How I did it
  • added a method _createAtChops in AtClientImpl. If atChops is not injected from at_client_mobile/at_onboarding_cli, then keys will be read from local secondary and atChops instance will be created.
  • removed use of EncryptionUtil in shared_key_decryption.dart, abstract_atkey_encryption.dart
  • removed code which reads from private key in monitor.dart
  • deprecated useAtChops experimental flag in AtClientPreference. Removed all references in at_client
  • removed call to SignInPublicData.signData in put_request_transformer.dart
  • refactored unit tests to remove references to useAtChops and mocked atChops where required
  • removed references to AtClientPreference.privateKey in tests
  • added a method in functional tests TestUtils.initAtClient(atSign, namespace); This will create at_chops instance and set it in the call to AtClientManager.setCurrentAtSign and also removes duplicate code in setUpAll methods in functional tests
    - How to verify it
  • unit and functional tests should pass
  • sanity in apps/cli with this branch of at_client.
    @purnimavenkatasubbu Please take this up.

@murali-shris murali-shris marked this pull request as ready for review October 20, 2023 07:31
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @murali-shris

@gkc gkc merged commit 2f8f3ff into trunk Oct 20, 2023
7 checks passed
@gkc gkc deleted the at_chops_default_true branch October 20, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants