ci: use virtual environment in functional tests #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyTubongbanua
changed the title
packages/atclient/src/connection.c
Outdated
Comment on lines
791
to
642
| void atclient_connection_set_read_timeout(atclient_connection *ctx, const uint32_t timeout_ms) { | ||
| if (ctx == NULL) { | ||
| atlogger_log(TAG, ATLOGGER_LOGGING_LEVEL_ERROR, "ctx is NULL\n"); | ||
| return; | ||
| } | ||
|
|
||
| mbedtls_ssl_conf_read_timeout(&(ctx->ssl_config), timeout_ms); | ||
| } | ||
|
|
There was a problem hiding this comment.
Doesn't this method already exist? I recall editing this in the changes for #475
There was a problem hiding this comment.
We only use a few sets of keys, can you remove the excess ones
There was a problem hiding this comment.
Done here
|
|
||
| CONTAINER_NAME="virtualenv" | ||
|
|
||
| sudo docker exec "$CONTAINER_NAME" supervisorctl start pkamLoad |
There was a problem hiding this comment.
don't put sudo in the script. Most systems should have configured docker so that it doesn't need super user permissions.
There was a problem hiding this comment.
Done in fb2e8a3
JeremyTubongbanua
force-pushed
the
jt/venv
branch
from
7c1256e to
56e318f
Compare
JeremyTubongbanua
force-pushed
the
jt/venv
branch
3 times, most recently
from
2321e0a to
3dfebc3
Compare
JeremyTubongbanua
force-pushed
the
jt/venv
branch
from
00b40bc to
7feb7ad
Compare
cpswan
approved these changes
Jan 2, 2025
| run: | | ||
| mkdir -p ~/.atsign/keys/ | ||
| echo "${{ secrets.ATKEYS_12ALPACA }}" > ~/.atsign/keys/@12alpaca_key.atKeys | ||
| echo "${{ secrets.ATKEYS_12SNOWBOATING }}" > ~/.atsign/keys/@12snowboating_key.atKeys | ||
| ls -la |
| - name: Add vip.ve.atsign.zone to /etc/hosts | ||
| run: | | ||
| echo "127.0.0.1 vip.ve.atsign.zone" | sudo tee -a /etc/hosts | ||
| cat /etc/hosts |
| sudo apt-get update | ||
| sudo apt-get install -y docker-compose | ||
| sudo ./start_virtualenv.sh | ||
| sleep 5 |
There was a problem hiding this comment.
Is it possible to test for the services being ready rather than sleeping?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #211
- What I did
Functional tests
ATDIRECTORY_HOSTandATDIRECTORY_PORToptions to the functional test's CMakeLists.txtint functional_tests_set_up_atkeys(atclient_atkeys *atkeys, const char *atsign);andint functional_tests_pkam_auth(atclient *atclient, atclient_atkeys *atkeys, const char *atsign);atclient
void atclient_connection_set_read_timeout(atclient_connection *ctx, const uint32_t timeout_ms);inconnection.catclient_set_read_timeout(inatclient.c) to use the new function mentioned above- How to verify it
- Description for the changelog
ci: use virtual environment in functional tests