Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and factorize spawn functions #793

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Aug 26, 2023

Implement erlang:spawn_link/1,3
Fix options of spawn_opt/2 by factorizing it with spawn_opt/4
Also rewrite spawn/1 and spawn/3 in Erlang and update tests accordingly
Also isolate libs tests

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w34/add-spawn_link branch from 2503708 to b38d161 Compare August 26, 2023 21:39
@pguyot pguyot mentioned this pull request Aug 26, 2023
@pguyot pguyot force-pushed the w34/add-spawn_link branch from b38d161 to 26d918f Compare August 29, 2023 05:23
@pguyot pguyot marked this pull request as ready for review August 29, 2023 05:25
Copy link
Collaborator

@fadushin fadushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of these changes, but they do have a potential impact on some test scenarios I believe @bettio may be using, so I would want him to weigh in.

libs/estdlib/src/erlang.erl Outdated Show resolved Hide resolved
libs/estdlib/src/erlang.erl Show resolved Hide resolved
libs/etest/src/etest.erl Show resolved Hide resolved
tests/erlang_tests/copy_terms0.erl Show resolved Hide resolved
tests/erlang_tests/test_refc_binaries.erl Show resolved Hide resolved
tests/libs/estdlib/test_spawn.erl Show resolved Hide resolved
@pguyot pguyot force-pushed the w34/add-spawn_link branch from 26d918f to 32c5dbe Compare August 31, 2023 19:18
Implement `erlang:spawn_link/1,3`
Fix options of `spawn_opt/2` by factorizing it with `spawn_opt/4`
Also rewrite `spawn/1` and `spawn/3` in Erlang and update tests accordingly
Also isolate libs tests
Also move types declaration in erlang module to the top

Signed-off-by: Paul Guyot <[email protected]>
@bettio bettio merged commit 466948f into atomvm:master Sep 4, 2023
@pguyot pguyot deleted the w34/add-spawn_link branch September 5, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants