Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fun_info/2 #1351
base: main
Are you sure you want to change the base?
Add fun_info/2 #1351
Changes from all commits
da4070f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We either keep
Context *ctx
as first parameter, or last one, according if it is the "main focus" of the function or not, I would move it as last parameter. I'm not sure I did explain in a a clear way this point, so feel free to ask clarifications.Here
Context *ctx
should be the last parameter.Also as an additional feedback, I suggest avoiding using
Context
interm.h
, since that would add an unnecessary coupling withContext
, while we likely just need having aGlobalContext
and aHeap
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of simplicity we might make the assumption that the fun takes less than 2^28 parameters, so we remove any boxed integer from here and we don't need any access to a Heap.