Fix indexing integer overflow for 15-bit window #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #86
A 15-bit window with a filled input buffer can result in an integer overflow in
do_indexing
. This PR addresses the problem by making the end bound inclusive.One solution I came up with to actually get indexing to work for a 15-bit window was to make the index an unsigned 16-bit integer array with 0xFFFF representing end-of-list.