Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test project for STM32F401 microcontroller #58

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

siorpaes
Copy link

Hello,

I just added a test project for popular STM32F401 microcontroller which decodes a test file and computes its md5 checksum for reference.
The project is based on Keil and can easily be adapted to other ST microcontrollers and IDEs using CubeMX.

@silentbicycle
Copy link
Collaborator

I'm hesitant to vendor all the generated drivers/etc. into this repo, since it's quite a lot of files for a very specific example. This might be better off as a separate project?

@BenBE
Copy link

BenBE commented Jul 4, 2021

The only things required to generate those vendored driver files is test_heatshrink_stm32f401.ioc and the heatshrink directory. If additionally you could tell CubeMX to not generate the main function itself you could separate out the demo source completely, which would make the demo much more versatile.

Also there are several places in the code that are technically unsatisfactory, like header files missing proper include guards, inconsistent indentation, mixing of several external libraries, much too broad configuration of the MCU (why configure the CAN bus if you're not using it?) and many other things. Last but not least, there's some system-specific pathnames in the .mxproject file, which like most other dot files shouldn't under version control to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants