Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

change xcode_settings in binding.gyp for universal macOs build #415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poisonReact
Copy link

🍎

  • makes node.keytar work on arm64 and x86 architecture

@kaatt
Copy link

kaatt commented Sep 16, 2021

Recommend against this, this will double the binary size. I have two separate builds for x64 and arm64 and only include the .node for the target arch.

@poisonReact
Copy link
Author

Recommend against this, this will double the binary size. I have two separate builds for x64 and arm64 and only include the .node for the target arch.

we are specially build a universal version for macOs application so as not to confuse users

@maccman
Copy link

maccman commented Sep 22, 2021

Looking forward to this one!

@benoist
Copy link

benoist commented Jan 16, 2022

Only way for us to use keytar on a universal build was to use this pull request in combination with buildDependenciesFromSource in the electron-builder file

Using the prebuilt adds a keytar.node to the asar file that is not universal
Using the pull request correctly adds a universal keytar.node

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants