Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: startup deadlock #50

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: startup deadlock #50

merged 1 commit into from
Oct 2, 2024

Conversation

mvarendorff2
Copy link
Member

This PR fixes a deadlock in startup that occurs when placing .AddEventSourcing() before .AddPostgresEventSourcingRepository(). This caused the the SideEffectDispatcher to wait for Upcasting to be finished while the Upcaster as HostedService waits for the SideEffectDispatcher StartAsync to finish.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.67%. Comparing base (949242e) to head (a7c3630).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Fluss.PostgreSQL/ServiceCollectionExtensions.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   66.62%   66.67%   +0.05%     
==========================================
  Files          75       75              
  Lines        2873     2878       +5     
  Branches      303      303              
==========================================
+ Hits         1914     1919       +5     
- Misses        906      907       +1     
+ Partials       53       52       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvarendorff2 mvarendorff2 merged commit d1a1c0a into main Oct 2, 2024
7 of 10 checks passed
@mvarendorff2 mvarendorff2 deleted the fix/startup-deadlock branch October 2, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant