Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that identifiers are generated based on the insertion order of nodes into the
AssetGraph
. I believe the determinism issues in V3 are a result of thePathRequest
requests occurring concurrently (I think they run on the main thread in V2 making the order deterministic).Having a deterministic insertion position on the
AssetGraph
is one solution (BTreeMap
based graph?), or alternatively identifiers could be be excluded from identifiers.In the meantime, a simple fix is to send a sorted graph back to JavaScript - ensuring that insertion order does not matter.
The serialized graph looks like:
It works but it's kinda gross. I'm fine with this approach being scrapped or incorporated temporarily as a stop-gap.