Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor domain sharding and support bundle-manifest requests #288

Merged
merged 27 commits into from
Dec 17, 2024
Merged

Refactor domain sharding and support bundle-manifest requests #288

merged 27 commits into from
Dec 17, 2024
+493 −605

Conversation

benjervis
Copy link
Contributor

Immediately after landing the domain sharding PR, I changed my mind about how it should work, partially driven by a desire to have the behaviour centralised into a package that can be imported by consuming services.

In this PR:

  • The sharding logic has been mostly moved to a new package, @atlaspack/domain-sharding
  • The sharding function now takes an absolute URL and applies the shards if necessary
  • The logic inside the JS Runtime has been reworked to use the new "just give me the whole URL" format
  • Sharding has been added to all usages of getBundleURL (after I found out that it wasn't being added to scope hoisting builds)

@benjervis
Add new package for domain sharding
17dc5c2
@benjervis
Add note about ESM syntax
fa3e8e5
@benjervis
Switch to sharding the final URL instead
a0c2af1
@benjervis
Bundle shards file no longer necessary
1593beb
@benjervis
Common can be moved back to bundle-url
aaceab4
@benjervis
Pass error into getBundleURL for testing
aa15b31
@benjervis
Convert to JSDoc
7512999
@benjervis
Add sharding to worker urls
116d960
@benjervis
Add sharding for bundle-manifest urls
2f1c7ad
@benjervis
Fix up the merge conflicts with JSDoc
5fda749
@benjervis
Add the window key as an exportable property
54670eb
@benjervis
Move some tests across to the new package
0ddd119
@benjervis
Add the new package to JS runtime
322de97
@benjervis
Rework the tests
f936293
@benjervis
Add an integration test for domain sharding
1604cba
@benjervis
Add unit test to bundle-url
60c02dd
@benjervis
Remove unused imports from test
20d9db3
@benjervis
Fix unit tests
3ce9b1d
@benjervis
Remove bundle-url-common from integration tests
5024a44
@benjervis
Fix the unit tests again
7cf488a
@benjervis
Export two more of the functions
d3fc976
@benjervis benjervis requested a review from a team December 17, 2024 07:43
@benjervis benjervis merged commit ec9d013 into main Dec 17, 2024
17 checks passed
@benjervis benjervis deleted the refactor-domain-sharding branch December 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaOlejniczak MonicaOlejniczak MonicaOlejniczak left review comments

@mattcompiles mattcompiles mattcompiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjervis @MonicaOlejniczak @mattcompiles