Reliability: Flow types for tests #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshdavid
force-pushed
the
alsh/add-flow-to-tests-8
branch
2 times, most recently
from
939486c to
bd70cc4
Compare
alshdavid
commented
Dec 16, 2024
There was a problem hiding this comment.
This fixture was being transpiled as flow implicitly. Converted it to commonjs to avoid flow transpilation
There was a problem hiding this comment.
/nit you could use modern mjs instead
alshdavid
force-pushed
the
alsh/add-flow-to-tests-8
branch
4 times, most recently
from
8431d76 to
38185d2
Compare
alshdavid
force-pushed
the
alsh/add-flow-to-tests-8
branch
from
38185d2 to
5259cd5
Compare
yamadapc
approved these changes
Dec 16, 2024
MonicaOlejniczak
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding flow types to tests