Copy new TypeScript files to lib #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding domain sharding, I migrated the bundle-url files to TypeScript so I would know what was going on in them.
Unfortunately this causes them to be skipped by the babel step in the gulpfile, which is only looking for
*.js.Adding TS into the babel compile step turned out to be a massive headache, so I've just added them to the copyOthers step.
When getting renamed later in the file, they depend on
vinyl.basebeingpackages/, so I've had to add some kind of glob syntax in that second path segment.