WIP - Warn if transformer does not update source-map #247
+110
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a warning if a transformer changes the asset source but does not update its source-map.
| let results = await normalizeAssets(this.options, transfomerResult); | ||
| const results = await normalizeAssets(this.options, transfomerResult); | ||
|
|
||
| if (mutableAsset.hasUpdatedSource && !mutableAsset.hasUpdatedSourceMap) { |
There was a problem hiding this comment.
Consider modifying this to check if a sourcemap exists yet. For example, some transformers rely on babel / swc to add the source map later and this will have correct mappings. You'd probably need to also add a check at the end to make sure a sourcemap exists after all pipelines run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a warning if a transformer changes the asset source but does not update its source-map.
WIP because I'll update this to remove non JS/TS warnings and to log only a reasonable amount.