Add changesets #126
Open
Add changesets #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| release-command: yarn canary:release | ||
| release-command: | | ||
| yarn canary:release | ||
| yarn changeset publish |
There was a problem hiding this comment.
Should we remove the lerna release then? Or are you moreso testing it out? Also, if we always publish on main then we should remove the tag-release workflow and associated commands. But, in saying that people might want a non-debug build too and having the generated pr for public releases is useful imo
There was a problem hiding this comment.
I will probably need to test this out a bit before being confident in it.
yamadapc
force-pushed
the
issue/add-changesets
branch
from
ae88d16 to
358e2e0
Compare
yamadapc
force-pushed
the
issue/add-changesets
branch
from
8c892b8 to
fc170e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to publish non-canary/pre-release versions to NPM on a rolling basis.
Starting with a minor bump and adding the release script to the canary workflow. Not sure if there's more that needs to be done here.