Skip to content

Commit

Permalink
[chore] [pdata] don't generate a cycle import in the internal package (
Browse files Browse the repository at this point in the history
…open-telemetry#8552)

To avoid warnings thrown by `make genpdata`:
```
go run pdata/internal/cmd/pdatagen/main.go
/Library/Developer/CommandLineTools/usr/bin/make fmt
package go.opentelemetry.io/collector/internal/fanoutconsumer
	imports go.opentelemetry.io/collector/component
	imports go.opentelemetry.io/collector/pdata/pcommon
	imports go.opentelemetry.io/collector/pdata/internal
	imports go.opentelemetry.io/collector/pdata/internal: import cycle not allowed
package go.opentelemetry.io/collector/internal/fanoutconsumer
	imports go.opentelemetry.io/collector/component
	imports go.opentelemetry.io/collector/pdata/pcommon
	imports go.opentelemetry.io/collector/pdata/internal
	imports go.opentelemetry.io/collector/pdata/internal: import cycle not allowed
```

The invalid imports are removed by `go fmt` after that anyway, but it's
still annoying.
  • Loading branch information
dmitryax authored Sep 27, 2023
1 parent 271debc commit d77d2c2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pdata/internal/cmd/pdatagen/internal/packages.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d77d2c2

Please sign in to comment.