[DCA11Y-1145] Node version manager support

.java-version

@@ -0,0 +1 @@
+1.8

CONTRIBUTING.md

@@ -0,0 +1,21 @@
+# Developing
+
+## Running tests locally
+
+### Run all invoker tests
+
+`mvn verify -PintegrationTests`
+
+### Run single invoker test
+
+`mvn verify -PintegrationTests -Dinvoker.test=<test-pattern>`
+
+## Docker images with node version managers
+
+### Build docker image
+
+`docker build -f docker/<node-version-manager>/Dockerfile -t fmp-local/base-with-<node-version-manager> ./docker`
+
+### Run project with docker image
+
+e.g. `docker run --rm -it -v $(pwd):/source -v ~/.m2:/root/.m2 fmp-local/base-with-<node-version-manager>` will mount project into /source directory

FORK_CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
+## [1.15.1-atlassian-4] - 2024-12-06
+
+### Added
+- [DCA11Y-1145]: Added support for using already installed node from default install directory of node version manager (fnm, mise, asdf, nvm, nvs). Use of version manager is enabled by default and can be controlled with `useNodeVersionManager` configuration property.
+
+### Changed
+- [DCA11Y-1145]: `nodeVersion` property is not required any more, if `useNodeVersionManager` is not set to false
+
 ## [1.15.1-atlassian-3]  - 2024-11-29
 
 ### Fixed

README.md

@@ -52,6 +52,10 @@ Only Atlassians may release a new version, [follow this guide](https://hello.atl
 
 ## Usage guidance
 
+### Using Node Version Manager
+
+By default, node based goals will try to use a node available from one of supported node version managers (`fnm`, `mise`, `asdf`, `nvm`, `nvs`). If a given node version is not available `frontend-maven-plugin` will fallback to standard installation. You can disable this behaviour with `useNodeVersionManager` configuration property.
+
 ### Format of the Node version
 
 It shouldn't matter if the `v` prefix is present, e.g. `14.8.0` and `v14.8.0`.

docker/fnm/Dockerfile

@@ -0,0 +1,46 @@
+FROM docker.atl-paas.net/sox/buildeng/agent-baseagent:latest
+
+ARG MAVEN_VERSION=3.9.6
+ARG NODE_VERSION=20.11.0
+ARG YARN_VERSION=1.22.19
+ARG NODE_GYP_VERSION=10.0.1
+
+USER root
+ENV HOME /root
+
+#install all needed dependencies for common build and testing tools for AUI, WRM, etc.
+RUN apt-get update -y \
+    && apt-get install --no-install-recommends -y \
+      apt-utils \
+      bzip2 \
+      curl \
+      fontconfig \
+      libgtk2.0-0 \
+      libgtk-3-0 \
+      libgbm-dev \
+      libnotify-dev \
+      libgconf-2-4 \
+      libnss3 \
+      libxss1 \
+      libasound2 \
+      libxtst6 \
+      libxss1 \
+      vim \
+      xauth \
+      xmlstarlet \
+      xvfb \
+      zip \
+    && rm -rf /var/lib/apt/lists/*
+
+# Remobve "global" node
+RUN rm /usr/bin/node \
+  && rm -rf /usr/lib/node_modules
+
+# Prebake latest maven
+RUN cd $HOME \
+    && echo "mvn_version=$MAVEN_VERSION" > mvnvm.properties \
+    && mvn --version \
+    && rm mvnvm.properties
+
+# Install node version manager
+RUN curl -fsSL https://fnm.vercel.app/install | bash

docker/mise/Dockerfile

@@ -0,0 +1,46 @@
+FROM docker.atl-paas.net/sox/buildeng/agent-baseagent:latest
+
+ARG MAVEN_VERSION=3.9.6
+ARG NODE_VERSION=20.11.0
+ARG YARN_VERSION=1.22.19
+ARG NODE_GYP_VERSION=10.0.1
+
+USER root
+ENV HOME /root
+
+#install all needed dependencies for common build and testing tools for AUI, WRM, etc.
+RUN apt-get update -y \
+    && apt-get install --no-install-recommends -y \
+      apt-utils \
+      bzip2 \
+      curl \
+      fontconfig \
+      libgtk2.0-0 \
+      libgtk-3-0 \
+      libgbm-dev \
+      libnotify-dev \
+      libgconf-2-4 \
+      libnss3 \
+      libxss1 \
+      libasound2 \
+      libxtst6 \
+      libxss1 \
+      vim \
+      xauth \
+      xmlstarlet \
+      xvfb \
+      zip \
+    && rm -rf /var/lib/apt/lists/*
+
+# Remobve "global" node
+RUN rm /usr/bin/node \
+  && rm -rf /usr/lib/node_modules
+
+# Prebake latest maven
+RUN cd $HOME \
+    && echo "mvn_version=$MAVEN_VERSION" > mvnvm.properties \
+    && mvn --version \
+    && rm mvnvm.properties
+
+RUN curl https://mise.run | bash \
+    && echo 'eval "$(~/.local/bin/mise activate bash)"' >> ~/.bashrc

docker/nvm/Dockerfile

@@ -0,0 +1,45 @@
+FROM docker.atl-paas.net/sox/buildeng/agent-baseagent:latest
+
+ARG MAVEN_VERSION=3.9.6
+ARG NODE_VERSION=20.11.0
+ARG YARN_VERSION=1.22.19
+ARG NODE_GYP_VERSION=10.0.1
+
+USER root
+ENV HOME /root
+
+#install all needed dependencies for common build and testing tools for AUI, WRM, etc.
+RUN apt-get update -y \
+    && apt-get install --no-install-recommends -y \
+      apt-utils \
+      bzip2 \
+      curl \
+      fontconfig \
+      libgtk2.0-0 \
+      libgtk-3-0 \
+      libgbm-dev \
+      libnotify-dev \
+      libgconf-2-4 \
+      libnss3 \
+      libxss1 \
+      libasound2 \
+      libxtst6 \
+      libxss1 \
+      vim \
+      xauth \
+      xmlstarlet \
+      xvfb \
+      zip \
+    && rm -rf /var/lib/apt/lists/*
+
+# Remobve "global" node
+RUN rm /usr/bin/node \
+  && rm -rf /usr/lib/node_modules
+
+# Prebake latest maven
+RUN cd $HOME \
+    && echo "mvn_version=$MAVEN_VERSION" > mvnvm.properties \
+    && mvn --version \
+    && rm mvnvm.properties
+
+RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash

docker/nvs/Dockerfile

@@ -0,0 +1,47 @@
+FROM docker.atl-paas.net/sox/buildeng/agent-baseagent:latest
+
+ARG MAVEN_VERSION=3.9.6
+ARG NODE_VERSION=20.11.0
+ARG YARN_VERSION=1.22.19
+ARG NODE_GYP_VERSION=10.0.1
+
+USER root
+ENV HOME /root
+
+#install all needed dependencies for common build and testing tools for AUI, WRM, etc.
+RUN apt-get update -y \
+    && apt-get install --no-install-recommends -y \
+      apt-utils \
+      bzip2 \
+      curl \
+      fontconfig \
+      libgtk2.0-0 \
+      libgtk-3-0 \
+      libgbm-dev \
+      libnotify-dev \
+      libgconf-2-4 \
+      libnss3 \
+      libxss1 \
+      libasound2 \
+      libxtst6 \
+      libxss1 \
+      vim \
+      xauth \
+      xmlstarlet \
+      xvfb \
+      zip \
+    && rm -rf /var/lib/apt/lists/*
+
+# Remobve "global" node
+RUN rm /usr/bin/node \
+  && rm -rf /usr/lib/node_modules
+
+# Prebake latest maven
+RUN cd $HOME \
+    && echo "mvn_version=$MAVEN_VERSION" > mvnvm.properties \
+    && mvn --version \
+    && rm mvnvm.properties
+
+RUN export NVS_HOME="$HOME/.nvs" \
+    && git clone https://github.com/jasongin/nvs "$NVS_HOME" \
+    && . "$NVS_HOME/nvs.sh" install

frontend-maven-plugin/pom.xml

@@ -119,7 +119,7 @@
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-invoker-plugin</artifactId>
-            <version>3.6.0</version>
+            <version>3.8.0</version>
 
             <configuration>
               <debug>true</debug>
@@ -132,6 +132,12 @@
               <filterProperties>
                 <repository.proxy.url>${repository.proxy.url}</repository.proxy.url>
               </filterProperties>
+              <pomIncludes>
+                <pomInclude>**/pom.xml</pomInclude>
+              </pomIncludes>
+              <pomExcludes>
+                <pomExclude>**/sub*/pom.xml</pomExclude>
+              </pomExcludes>
             </configuration>
 
             <executions>

frontend-maven-plugin/src/it/custom-install-directory/pom.xml

@@ -17,6 +17,7 @@
 
                 <configuration>
                     <installDirectory>target</installDirectory>
+                    <useNodeVersionManager>false</useNodeVersionManager>
                 </configuration>
 
                 <executions>

frontend-maven-plugin/src/it/custom-working-directory/pom.xml

@@ -17,6 +17,7 @@
 
                 <configuration>
                     <workingDirectory>src/main/frontend</workingDirectory>
+                    <useNodeVersionManager>false</useNodeVersionManager>
                 </configuration>
 
                 <executions>

frontend-maven-plugin/src/it/example project/pom.xml

@@ -16,6 +16,10 @@
         <!-- NB! Set <version> to the latest released version of frontend-maven-plugin, like in README.md -->
         <version>@project.version@</version>
 
+        <configuration>
+          <useNodeVersionManager>false</useNodeVersionManager>
+        </configuration>
+
         <executions>
 
           <execution>

frontend-maven-plugin/src/it/node-provided-npm/pom.xml

@@ -17,6 +17,7 @@
 
                 <configuration>
                     <installDirectory>target</installDirectory>
+                    <useNodeVersionManager>false</useNodeVersionManager>
                 </configuration>
 
                 <executions>

frontend-maven-plugin/src/it/node-version-manager/asdf/.tool-versions

@@ -0,0 +1 @@
+nodejs 20.15.1

frontend-maven-plugin/src/it/node-version-manager/asdf/install-asdf.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+# invoker env variables are not loaded yet
+export HOME="$(dirname "$0")"
+
+export ASDF_DIR="$HOME/.asdf";
+mkdir "$ASDF_DIR"
+echo "ASDF_DIR set: $ASDF_DIR";
+
+git clone https://github.com/asdf-vm/asdf.git "$ASDF_DIR" --branch v0.14.1
+echo "ASDF checked out";
+
+. "$HOME/.asdf/asdf.sh" \
+  && asdf plugin add nodejs \
+  && asdf install nodejs v20.15.1

frontend-maven-plugin/src/it/node-version-manager/asdf/invoker.properties

@@ -0,0 +1,2 @@
+invoker.environmentVariables.HOME=${basedir}/target/it/node-version-manager/asdf
+invoker.environmentVariables.ASDF_DIR=${basedir}/target/it/node-version-manager/asdf/.asdf

frontend-maven-plugin/src/it/node-version-manager/asdf/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "example",
+  "version": "0.0.1",
+  "dependencies": {
+    "classnames": "^2.3.2"
+  },
+  "scripts": {
+    "prebuild": "npm install"
+  }
+}