DCA11Y-1145: Support standard Node version files #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more likely to contain the files we're after as they're often colocated
atl-mk
commented
Jul 24, 2024
...n-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionDetector.java
Show resolved
Hide resolved
gt-lassian
approved these changes
Jul 24, 2024
...gin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionParser.java
Outdated
Show resolved
Hide resolved
rafalsatl
reviewed
Jul 29, 2024
...gin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndNpmMojo.java
Show resolved
Hide resolved
rafalsatl
reviewed
Jul 29, 2024
...gin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndNpmMojo.java
Outdated
Show resolved
Hide resolved
rafalsatl
reviewed
Jul 29, 2024
...n-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionDetector.java
Show resolved
Hide resolved
rafalsatl
reviewed
Jul 29, 2024
...n-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionDetector.java
Show resolved
Hide resolved
rafalsatl
approved these changes
Jul 29, 2024
flipatlas
reviewed
Sep 20, 2024
...n-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionDetector.java
Show resolved
Hide resolved
atl-mk
force-pushed
the
issue/master/DCA11Y-1145-support-standard-node-version-files
branch
from
c645409 to
9429520
Compare
atl-mk
force-pushed
the
issue/master/DCA11Y-1145-support-standard-node-version-files
branch
4 times, most recently
from
cfbc71b to
c0fc4aa
Compare
atl-mk
force-pushed
the
issue/master/DCA11Y-1145-support-standard-node-version-files
branch
from
c0fc4aa to
13eb4d1
Compare
atl-mk
added a commit
that referenced
this pull request
Sep 22, 2024
atl-mk
commented
Sep 27, 2024
...gin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionHelper.java
Show resolved
Hide resolved
atl-mk
commented
Sep 27, 2024
...gin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/NodeVersionHelper.java
Show resolved
Hide resolved
flipatlas
reviewed
Sep 30, 2024
| if (!nodeVersions.get().isPresent()) { | ||
| synchronized (NodeVersionHelper.class) { // avoiding racing sending multiple requests | ||
| try (CloseableHttpClient httpClient = HttpClients.createDefault()) { | ||
| HttpGet getNodeVersionIndex = new HttpGet("https://nodejs.org/dist/index.json"); |
There was a problem hiding this comment.
Should this be based on nodeDownloadRoot property maybe so that we can override node registry?
|
Topics to discuss raised by @rafalsatl during QA demo:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation changes should be self-sufficient.
The driving force is friction internal to Atlassian.