Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prompt buffer handling #3522

Closed
wants to merge 2 commits into from
Closed

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Oct 15, 2024

Description

Fixes #3489.

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/<renderer>))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg
Copy link
Member Author

aadcg commented Oct 16, 2024

I'm not happy with this iteration, since it adds even more lag to each prompt buffer invocation. Thinking.

@aadcg
Copy link
Member Author

aadcg commented Oct 17, 2024

Due to #3523, it is not possible to pursue this strategy that proposed creating a webview on each prompt buffer invocation.

Superseded by bac6949.

@aadcg aadcg closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Refactor architecture behind hide-prompt-buffer
1 participant