Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32 migrate to hal 10 #33

Merged
merged 5 commits into from
Dec 10, 2024
Merged

32 migrate to hal 10 #33

merged 5 commits into from
Dec 10, 2024

Conversation

HusseinAbdelhamid
Copy link
Contributor

No description provided.

@HusseinAbdelhamid HusseinAbdelhamid linked an issue Dec 5, 2024 that may be closed by this pull request
Migrate to HAL 1.0 #32
Closed
marius-meissner
marius-meissner requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@marius-meissner marius-meissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Just one tiny suggestions (s. inline comment).

Maybe you can in addition the following targets to QA pipeline:

  • thumbv7m-none-eabi (Raspberry Pi)
  • thumbv8m.main-none-eabihf (RP2350)
  • riscv32imac-unknown-none-elf (RP2350 alternative)

src/example.rs Outdated Show resolved Hide resolved
@HusseinAbdelhamid
Copy link
Contributor Author

HusseinAbdelhamid commented Dec 9, 2024 •
edited
Loading

Requested changes addressed now 👍

marius-meissner
marius-meissner approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@marius-meissner marius-meissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marius-meissner marius-meissner merged commit 2c5b726 into main Dec 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-meissner marius-meissner marius-meissner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to HAL 1.0
2 participants
@HusseinAbdelhamid @marius-meissner