Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Device.d.ts #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed Device.d.ts #24

wants to merge 3 commits into from

Conversation

edwinvdpol
Copy link
Contributor

@edwinvdpol edwinvdpol commented Apr 13, 2024 •
edited
Loading

I see that all the on functions in Device.d.ts are being called like this on my Homey Pro (Early 2019):

await this.onAdded()
await this.onRenamed(this[sName])
await this.onDeleted()

This PR fixes the return types of these methods.

@edwinvdpol
Fixed Device.d.ts
c08a9eb 
I see that all the `on` functions in Device.d.ts are being called like this:

```
await this.onAdded()
...
await this.onDeleted()
```
@edwinvdpol
Merge branch 'athombv:master' into patch-1
f70e5e0
@edwinvdpol
Merge branch 'athombv:master' into patch-1
6cb72fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edwinvdpol