functon which can redact device log fields

[eelco2k]

No description provided.

[bobvandevijver]

Thank you for the PR! It is actually less important in the log (which should remain local as we no longer request people to use the CLI to create their requests), but it does need to be sanitized in the other driver where the settings are generated:

com.tuya/drivers/other/driver.js

Line 18 in 5767e19

props.settings["deviceSpecification"] = JSON.stringify(

Can you add it there as well, and lets add the following fields as well. For my part you can make this the default list for the function, so we do not need to pass the same list twice.

• owner_id
• uid
• uuid
• local_key

[eelco2k]

added your requests. But i did not use it as default list but as these fields always need to be redacted i combine the list with the incoming array of second param of the redactFields function. that way you cannot override and miss the ip,lat,lon etc. fields

[bobvandevijver]

Many thanks @eelco2k! I did find a small bug, but fixed that. Will be pushing a release with this soon.

[eelco2k]

perfect! I did not test the code so good you found that bugger 👍

[eelco2k]

does the line :
this.log('Device:', JSON.stringify(TuyaOAuth2Util.redactFields(device)));
not be:
this.log('Device:', JSON.stringify(TuyaOAuth2Util.redactFields(device.device)));

i'm not completely sure...? as the json has 2 keys, "device" and "specifications" ...

[bobvandevijver]

No, that was actually the source of the bug. The JSON with two keys is not returned by Tuya, but constructed by us in the other driver.

com.tuya/drivers/other/driver.js

Line 14 in ca04e22

const combinedSpecification = {

[eelco2k]

yes i understand, on the driver.js i understand, but i mean in the [lib/TuyaOAuth2Driver.js] file in the onPairListDevices() function. is it there also correct? if so. i have said nothing.. :)

[bobvandevijver]

The TuyaOAuth2Driver.js onPairListDevices function does not yet have the specification part (that is line 23), so yes, it is correct as it is now 👍🏻