fix: add scrollable Community dropdown to display all content #3553
Conversation
rahulrana701
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces modifications to the Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
❌ Deploy Preview for asyncapi-website failed.Built without sensitive environment variables
|
rahulrana701
changed the title
rahulrana701
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3553--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
components/navigation/FlyoutMenu.tsx (1)
Missing tailwind-scrollbar plugin for custom scrollbar styles
The component uses Tailwind scrollbar classes (
scrollbar-thin,scrollbar-thumb-white,scrollbar-track-transparent) but the requiredtailwind-scrollbarplugin is not configured in the project. These classes won't have any effect on the scrollbar styling.To fix this:
- Install the
tailwind-scrollbarplugin- Add it to the plugins array in
tailwind.config.js- Or replace the current classes with custom CSS scrollbar styling using the existing
.scroll-noneutility as a reference🔗 Analysis chain
Line range hint
1-27: Well-structured implementation of scrollable dropdown.The component effectively implements a scrollable dropdown with appropriate height constraints and maintains good TypeScript practices. The changes successfully address the PR objective of making the Community dropdown scrollable.
Let's verify the scrollbar plugin dependency:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if tailwind-scrollbar plugin is properly configured grep -r "tailwindcss/scrollbar\|tailwind-scrollbar" .Length of output: 55
Script:
#!/bin/bash # Check package.json for tailwind-scrollbar dependency cat package.json | grep -A 5 -B 5 "scrollbar" # Check tailwind configuration files fd -e js -e cjs -e ts "tailwind.config" --exec cat {}Length of output: 5848
🧰 Tools
🪛 eslint
[error] 17-17: Replace
"absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2"with'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace
"Flyout-main"with'Flyout-main'(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace
"rounded-lg·shadow-lg"with'rounded-lg·shadow-lg'(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace
"shadow-xs·overflow-hidden·rounded-lg"with'shadow-xs·overflow-hidden·rounded-lg'(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace
"relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent"with'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-21: Double quotes used instead of single quotes for JSX attributes
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/navigation/FlyoutMenu.tsx(1 hunks)
🧰 Additional context used
🪛 eslint
components/navigation/FlyoutMenu.tsx
[error] 17-17: Replace "absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2" with 'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'
(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace "Flyout-main" with 'Flyout-main'
(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace "rounded-lg·shadow-lg" with 'rounded-lg·shadow-lg'
(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace "shadow-xs·overflow-hidden·rounded-lg" with 'shadow-xs·overflow-hidden·rounded-lg'
(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace "relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent" with 'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'
(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
components/navigation/FlyoutMenu.tsx
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-21: Double quotes used instead of single quotes for JSX attributes
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
components/navigation/FlyoutMenu.tsx
Outdated
| className="absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2" | ||
| data-testid="Flyout-main" | ||
| > | ||
| <div className='rounded-lg shadow-lg'> | ||
| <div className='shadow-xs overflow-hidden rounded-lg'> | ||
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | ||
| <div className="rounded-lg shadow-lg"> | ||
| <div className="shadow-xs overflow-hidden rounded-lg"> | ||
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> |
There was a problem hiding this comment.
Fix quote style to match project conventions.
Replace double quotes with single quotes in JSX attributes to comply with project conventions and fix CI failures.
Apply this change across all JSX attributes:
- className="absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2"
+ className='absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2'
- data-testid="Flyout-main"
+ data-testid='Flyout-main'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| className="absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2" | |
| data-testid="Flyout-main" | |
| > | |
| <div className='rounded-lg shadow-lg'> | |
| <div className='shadow-xs overflow-hidden rounded-lg'> | |
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | |
| <div className="rounded-lg shadow-lg"> | |
| <div className="shadow-xs overflow-hidden rounded-lg"> | |
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> | |
| className='absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2' | |
| data-testid='Flyout-main' | |
| > | |
| <div className='rounded-lg shadow-lg'> | |
| <div className='shadow-xs overflow-hidden rounded-lg'> | |
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent'> |
🧰 Tools
🪛 eslint
[error] 17-17: Replace "absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2" with 'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'
(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace "Flyout-main" with 'Flyout-main'
(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace "rounded-lg·shadow-lg" with 'rounded-lg·shadow-lg'
(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace "shadow-xs·overflow-hidden·rounded-lg" with 'shadow-xs·overflow-hidden·rounded-lg'
(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace "relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent" with 'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'
(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-21: Double quotes used instead of single quotes for JSX attributes
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
components/navigation/FlyoutMenu.tsx
Outdated
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | ||
| <div className="rounded-lg shadow-lg"> | ||
| <div className="shadow-xs overflow-hidden rounded-lg"> | ||
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Review scrollbar visibility and fix class ordering.
Two concerns with the scrollbar implementation:
- A white scrollbar thumb (
scrollbar-thumb-white) on a white background (bg-white) might be difficult to see. - Tailwind classes should follow the recommended ordering convention.
Consider these improvements:
- Use a different color for better contrast:
- <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent">
+ <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent">- Reorder Tailwind classes following the convention:
- <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent">
+ <div className="relative z-20 max-h-96 min-h-40 grid gap-6 bg-white px-5 py-6 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent sm:gap-8 sm:p-8 lg:grid-cols-2">📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div className="relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2 max-h-96 min-h-40 overflow-y-auto scrollbar-thin scrollbar-thumb-white scrollbar-track-transparent"> | |
| <div className="relative z-20 max-h-96 min-h-40 grid gap-6 bg-white px-5 py-6 overflow-y-auto scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent sm:gap-8 sm:p-8 lg:grid-cols-2"> |
🧰 Tools
🪛 eslint
[error] 22-22: Replace "relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent" with 'relative·z-20·grid·gap-6·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2·max-h-96·min-h-40·overflow-y-auto·scrollbar-thin·scrollbar-thumb-white·scrollbar-track-transparent'
(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[warning] 22-22: Invalid Tailwind CSS classnames order
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 668 668
=========================================
Hits 668 668 ☔ View full report in Codecov by Sentry. |
components/navigation/FlyoutMenu.tsx
Outdated
| @@ -19,7 +19,7 @@ export default function Flyout({ items = [] }: FlyoutProps) { | |||
| > | |||
| <div className='rounded-lg shadow-lg'> | |||
| <div className='shadow-xs overflow-hidden rounded-lg'> | |||
| <div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | |||
| <div className='scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent relative z-20 grid max-h-96 min-h-40 gap-6 overflow-y-auto bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'> | |||
There was a problem hiding this comment.
Why are you limiting the maximum height of the dropdown? It should go as much as the screen size allows, and then the scrollbar for overflow content can be displayed.
There was a problem hiding this comment.
I made this change for a better UI experience, but I’ll fix it.
There was a problem hiding this comment.
@anshgoyalevil done as suggested
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
components/navigation/FlyoutMenu.tsx (2)
20-21: Fix quotes and optimize nested structure
- Replace double quotes with single quotes
- Consider combining shadow classes to reduce nested divs for better performance
- <div className="rounded-lg shadow-lg"> - <div className="shadow-xs overflow-hidden rounded-lg"> + <div className='rounded-lg shadow-lg overflow-hidden'>🧰 Tools
🪛 eslint
[error] 20-20: Replace
"rounded-lg·shadow-lg"with'rounded-lg·shadow-lg'(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace
"shadow-xs·overflow-hidden·rounded-lg"with'shadow-xs·overflow-hidden·rounded-lg'(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 20-20: Double quotes used instead of single quotes for JSX attributes
[error] 21-21: Double quotes used instead of single quotes for JSX attributes
Line range hint
1-29: Consider architectural improvements for better performanceGiven the low performance score (48) in the Lighthouse report, consider these architectural improvements:
- Implement lazy loading for menu items
- Use intersection observer to detect scroll position
- Consider breaking down MenuBlocks into smaller components
- Add proper
aria-*attributes for better accessibilityWould you like me to provide a detailed implementation for any of these suggestions?
🧰 Tools
🪛 eslint
[error] 17-17: Replace
"absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2"with'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace
"Flyout-main"with'Flyout-main'(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace
"rounded-lg·shadow-lg"with'rounded-lg·shadow-lg'(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace
"shadow-xs·overflow-hidden·rounded-lg"with'shadow-xs·overflow-hidden·rounded-lg'(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace
"scrollbar-thin·scrollbar-thumb-gray-400·scrollbar-track-transparent·relative·z-20·grid·max-h-[calc(100vh-20px)]·gap-6·overflow-y-auto·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2"with'scrollbar-thin·scrollbar-thumb-gray-400·scrollbar-track-transparent·relative·z-20·grid·max-h-[calc(100vh-20px)]·gap-6·overflow-y-auto·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2'(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-20: Double quotes used instead of single quotes for JSX attributes
[error] 21-21: Double quotes used instead of single quotes for JSX attributes
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/navigation/FlyoutMenu.tsx(1 hunks)
🧰 Additional context used
🪛 eslint
components/navigation/FlyoutMenu.tsx
[error] 17-17: Replace "absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2" with 'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'
(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace "Flyout-main" with 'Flyout-main'
(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
[error] 20-20: Replace "rounded-lg·shadow-lg" with 'rounded-lg·shadow-lg'
(prettier/prettier)
[error] 20-20: Unexpected usage of doublequote.
(jsx-quotes)
[error] 21-21: Replace "shadow-xs·overflow-hidden·rounded-lg" with 'shadow-xs·overflow-hidden·rounded-lg'
(prettier/prettier)
[error] 21-21: Unexpected usage of doublequote.
(jsx-quotes)
[error] 22-22: Replace "scrollbar-thin·scrollbar-thumb-gray-400·scrollbar-track-transparent·relative·z-20·grid·max-h-[calc(100vh-20px)]·gap-6·overflow-y-auto·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2" with 'scrollbar-thin·scrollbar-thumb-gray-400·scrollbar-track-transparent·relative·z-20·grid·max-h-[calc(100vh-20px)]·gap-6·overflow-y-auto·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2'
(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
components/navigation/FlyoutMenu.tsx
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
[error] 20-20: Double quotes used instead of single quotes for JSX attributes
[error] 21-21: Double quotes used instead of single quotes for JSX attributes
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
🔇 Additional comments (2)
components/navigation/FlyoutMenu.tsx (2)
17-18:⚠️ Potential issueFix quote style to match project conventions
Replace double quotes with single quotes in JSX attributes to comply with project conventions and fix CI failures.
- className="absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2" - data-testid="Flyout-main" + className='absolute z-50 -ml-4 w-screen max-w-md pt-3 md:ml-12 md:-translate-x-1/2 lg:left-1/2 lg:max-w-3xl lg:-translate-x-1/2' + data-testid='Flyout-main'Likely invalid or redundant comment.
🧰 Tools
🪛 eslint
[error] 17-17: Replace
"absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2"with'absolute·z-50·-ml-4·w-screen·max-w-md·pt-3·md:ml-12·md:-translate-x-1/2·lg:left-1/2·lg:max-w-3xl·lg:-translate-x-1/2'(prettier/prettier)
[error] 17-17: Unexpected usage of doublequote.
(jsx-quotes)
[error] 18-18: Replace
"Flyout-main"with'Flyout-main'(prettier/prettier)
[error] 18-18: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 17-17: Double quotes used instead of single quotes for JSX attributes
[error] 18-18: Double quotes used instead of single quotes for JSX attributes
22-22: 🛠️ Refactor suggestionOptimize scrollable container implementation
Several concerns need to be addressed:
- Dynamic height calculation using
calc()might cause layout shifts and affect performance- Class ordering should follow Tailwind conventions
- Consider using CSS custom properties for better maintainability
- <div className="scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent relative z-20 grid max-h-[calc(100vh-20px)] gap-6 overflow-y-auto bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2"> + <div + className='relative z-20 grid gap-6 overflow-y-auto bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2' + style={{ + '--max-height': 'calc(100vh - var(--header-height, 20px))', + maxHeight: 'var(--max-height)' + }} + >Consider these improvements:
- Move height calculation to CSS custom properties for better performance
- Remove scrollbar styling classes as they might affect performance
- Use native scrollbar or lightweight alternatives
- Consider implementing virtual scrolling for large lists to improve performance
Let's verify the impact of the scrollbar implementation on performance:
🧰 Tools
🪛 eslint
[error] 22-22: Replace
"scrollbar-thin·scrollbar-thumb-gray-400·scrollbar-track-transparent·relative·z-20·grid·max-h-[calc(100vh-20px)]·gap-6·overflow-y-auto·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2"with'scrollbar-thin·scrollbar-thumb-gray-400·scrollbar-track-transparent·relative·z-20·grid·max-h-[calc(100vh-20px)]·gap-6·overflow-y-auto·bg-white·px-5·py-6·sm:gap-8·sm:p-8·lg:grid-cols-2'(prettier/prettier)
[error] 22-22: Unexpected usage of doublequote.
(jsx-quotes)
🪛 GitHub Actions: PR testing - if Node project
[error] 22-22: Double quotes used instead of single quotes for JSX attributes
The "Community" dropdown should display all its content, even if the content exceeds the available space. A scrollbar should appear when the dropdown content is too large, allowing users to scroll through the options.
#3549
Summary by CodeRabbit