Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplified error handling in build-dashboard.js #3521

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: simplified error handling in build-dashboard.js #3521

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63f45fe
simplified error handling in build-dashboard.js
sahitya-chandra Dec 28, 2024
ee5b5cc
some refactor
sahitya-chandra Dec 28, 2024
3581971
Merge branch 'master' into simple-error-handling
asyncapi-bot Dec 30, 2024
63204a2
Merge branch 'asyncapi:master' into simple-error-handling
sahitya-chandra Dec 31, 2024
5b1388e
added custom logservice using winston for error logging
sahitya-chandra Dec 31, 2024
562be7a
linting done
sahitya-chandra Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/dashboard/build-dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ async function getDiscussions(query, pageSize, endCursor = null) {
return result.search.nodes.concat(await getDiscussions(query, pageSize, result.search.pageInfo.endCursor));
} catch (e) {
console.error(e);
return Promise.reject(e);
throw e;
}
}

Expand All @@ -60,7 +60,7 @@ async function getDiscussionByID(isPR, id) {
return result;
} catch (e) {
console.error(e);
return Promise.reject(e);
throw e;
}
}

Expand Down Expand Up @@ -173,6 +173,7 @@ async function start(writePath) {
} catch (e) {
console.log('There were some issues parsing data from github.');
console.log(e);
throw e;
}
}

Expand Down
Loading