fix: alignment of two images #3505
Conversation
jalajk3004
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces minor layout and styling modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3505 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/tools/generator.tsx (1)
139-139: Remove trailing space in className.There's an unnecessary trailing space in the className string.
- <div className='relative -mx-4 mt-10 lg:mt-0 '> + <div className='relative -mx-4 mt-10 lg:mt-0'>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/tools/generator.tsx(2 hunks)
🔇 Additional comments (2)
pages/tools/generator.tsx (2)
57-57: LGTM! Good responsive spacing adjustment.
The addition of lg:gap-x-24 provides better horizontal spacing between content on larger screens while maintaining appropriate spacing on mobile devices.
140-141: 🛠️ Refactor suggestion
Improve image accessibility and performance.
The images need descriptive alt text for accessibility. Also, consider adding explicit width and height attributes to prevent Cumulative Layout Shift (CLS).
- <img className='relative mx-auto w-4/5 rounded shadow-lg' src='/img/tools/generator-1.png' alt='' />
- <img className='relative mx-auto w-4/5 mt-8 rounded shadow-lg' src='/img/tools/generator-2.png' alt='' />
+ <img
+ className='relative mx-auto w-4/5 rounded shadow-lg'
+ src='/img/tools/generator-1.png'
+ alt='AsyncAPI Generator interface screenshot'
+ width={800}
+ height={600}
+ />
+ <img
+ className='relative mx-auto w-4/5 mt-8 rounded shadow-lg'
+ src='/img/tools/generator-2.png'
+ alt='AsyncAPI Generator output example'
+ width={800}
+ height={600}
+ />Note: Replace the width and height values with the actual dimensions of your images.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3505--asyncapi-website.netlify.app/ |
|
@Mayaleeeee @akshatnema @anshgoyalevil @derberg @magicmatatjahu kindly review the Pull request |
|
@jalajk3004 Kindly file an issue with a clear description of the bug and wait for a triage. |
|
@anshgoyalevil I have made this Pull request inorder to fix the issue #3504. |
Description
ScreenShot
Summary by CodeRabbit
New Features
Chores