Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update generator.tsx Removed the extra buttons from the generator page #3490

Conversation

BalrajDhakad
Copy link

@BalrajDhakad BalrajDhakad commented Dec 19, 2024

Description

Removed the extra buttons from the Generator page.

Screenshots

Before Fix
Screenshot 2024-12-19 at 8 01 43 PM

After Fix
Screenshot 2024-12-19 at 8 01 50 PM

Issues Resolved
#3489

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the layout of the GeneratorPage by removing button rendering from the "Installation & Usage" section, improving content presentation.

Copy link

coderabbitai bot commented Dec 19, 2024

Walkthrough

The pull request modifies the GeneratorPage component in pages/tools/generator.tsx by removing the renderButtons() function call from the "Installation & Usage" section. This change affects the button layout, removing buttons from the installation instructions area while keeping them at the bottom of the page. The modification appears to be a structural adjustment to the component's presentation.

Changes

File Change Summary
pages/tools/generator.tsx Removed renderButtons() call from the "Installation & Usage" section

Possibly related issues

  • asyncapi/website#3489: This issue directly aligns with the PR changes, suggesting removing duplicate buttons from the generator page to improve user experience and page aesthetics.

Poem

🐰 A button's journey, now refined,
Hopping from here to there, redesigned!
No longer cluttered, clean and bright,
The generator page now feels just right.
A rabbit's touch of UI delight! 🎨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c90b564 and d376128.

📒 Files selected for processing (1)
  • pages/tools/generator.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • pages/tools/generator.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d376128
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/67642f1f61104600081564ca
😎 Deploy Preview https://deploy-preview-3490--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BalrajDhakad BalrajDhakad changed the title feature: update generator.tsx Removed the extra buttons from the generator page feat: update generator.tsx Removed the extra buttons from the generator page Dec 19, 2024
@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 38
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3490--asyncapi-website.netlify.app/

@anshgoyalevil
Copy link
Member

The btns removed were actually intentional.

@BalrajDhakad BalrajDhakad deleted the Removing-the-buttons-from-the-generator-page branch December 20, 2024 02:40
@BalrajDhakad
Copy link
Author

Okay, thanks for responding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants