Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverted the package of mdx/js loader #2887

Conversation

TenzDelek
Copy link
Contributor

@TenzDelek TenzDelek commented Apr 18, 2024

Fixes #2886
Reverts #2884

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df6721a
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66213b71d0f1eb0008b60ca9
😎 Deploy Preview https://deploy-preview-2887--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Apr 18, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2887--asyncapi-website.netlify.app/

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Apr 18, 2024

@TenzDelek for now we are merging this PR but we need to make changes according to the new package version as this might happen again

@TenzDelek
Copy link
Contributor Author

@sambhavgupta0705 ok will look into this

@sambhavgupta0705
Copy link
Member

@TenzDelek what node version have you used to upgrade the version?

@TenzDelek
Copy link
Contributor Author

TenzDelek commented Apr 18, 2024

@sambhavgupta0705 currently on node v20.10.0. by upgrade I assume you are saying about the reverting one. or if you are talking about the solution for the version 3, currently haven't started yet, reading their docs for now, they have mention some changes for migrating to v3.

@anshgoyalevil
Copy link
Member

Thanks for the PR @TenzDelek! 😄 However, I think we should revert the changes directly from the merged PR page to maintain clarity and consistency. Merging a new PR with a manual revert might create unnecessary changes.
ref: #2889

@TenzDelek TenzDelek changed the title fix: reverted the package of mdx/js loader fix: revert "chore(deps): bump loader-utils and @mdx-js/loader" Apr 18, 2024
@TenzDelek TenzDelek changed the title fix: revert "chore(deps): bump loader-utils and @mdx-js/loader" fix: reverted the package of mdx/js loader Apr 18, 2024
@TenzDelek
Copy link
Contributor Author

TenzDelek commented Apr 18, 2024

Thanks for the PR @TenzDelek! 😄 However, I think we should revert the changes directly from the merged PR page to maintain clarity and consistency. Merging a new PR with a manual revert might create unnecessary changes. ref: #2889

@anshgoyalevil oh that sound reasonable. will close this pr then

@TenzDelek TenzDelek closed this Apr 18, 2024
@TenzDelek TenzDelek deleted the fix/revert-the-package-of-mdx-jsloader branch April 18, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert the package of mdx/js loader
4 participants