-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reverted the package of mdx/js loader #2887
fix: reverted the package of mdx/js loader #2887
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2887--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TenzDelek for now we are merging this PR but we need to make changes according to the new package version as this might happen again |
@sambhavgupta0705 ok will look into this |
@TenzDelek what node version have you used to upgrade the version? |
@sambhavgupta0705 currently on node v20.10.0. by upgrade I assume you are saying about the reverting one. or if you are talking about the solution for the version 3, currently haven't started yet, reading their docs for now, they have mention some changes for migrating to v3. |
Thanks for the PR @TenzDelek! 😄 However, I think we should revert the changes directly from the merged PR page to maintain clarity and consistency. Merging a new PR with a manual revert might create unnecessary changes. |
@anshgoyalevil oh that sound reasonable. will close this pr then |
Fixes #2886
Reverts #2884