Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: re-add message validation guide and change code snippet #2282

Conversation

AnimeshKumar923
Copy link
Contributor

Description

  • Re-added the message validation guide in the next-major-spec branch.
  • Changed the code snippet to match v3.

Related issue(s)
Fixes #1865

changes:

- Re-added the `message validation guide` in
the next-major-spec branch.
- Changed the code snippet to match v3.
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit bac086f
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/654bdfc356a2a2000872190b
😎 Deploy Preview https://deploy-preview-2282--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnimeshKumar923 thanks a 💯 mate. I thought I will have to do all these PRs. Just please update code sample

@alequetzalli please review, below you can see in a diff tool I used that previous guide was re-added correctly and only code sample was modified. I also read the guide and no other changes need to happen

Screenshot 2023-11-08 at 16 05 54

pages/docs/guides/message-validation.md Outdated Show resolved Hide resolved
applied suggestion from: asyncapi#2282 (comment)

Co-authored-by: Lukasz Gornicki <[email protected]>
@AnimeshKumar923
Copy link
Contributor Author

AnimeshKumar923 commented Nov 8, 2023

@AnimeshKumar923 thanks a 💯 mate. I thought I will have to do all these PRs. Just please update code sample

Just did what I was able to did. Glad to help! 😁
Let me know if there is any more issues I can help with, I'll try that...

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 9de2795 into asyncapi:next-major-spec Nov 10, 2023
9 checks passed
@AnimeshKumar923 AnimeshKumar923 deleted the adapt-message-validation-guide-for-v3 branch November 11, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants