docs: re-add studio document validation and change code snippet
#2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: - Re-added the `studio document validation` in the next-major-spec branch. - Changed the code snippet to match v3.
AnimeshKumar923
requested review from
quetzalliwrites and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
derberg
reviewed
Nov 8, 2023
Comment on lines
17
to
21
| <Remember> | ||
|
|
||
| If you did not follow the previous tutorial and do not have an `asyncapi.yaml` file ready, then generate one using `asyncapi new --example=tutorial.yml --no-tty` command. | ||
|
|
||
| </Remember> |
There was a problem hiding this comment.
I don't think this should be here in this tutorial as this tutorial is about validating invalid document in studio, basing on example provided in studio - and command under remember note talks about generating a valid document
There was a problem hiding this comment.
@derberg
okay, so if the command generates a valid document, it should not be there. Any command to generate and invalid one? If not there is a way to generate one from AsyncAPI Studio as far as I've tested. Thoughts? 👀
applied suggestion from: asyncapi#2276 (comment) Co-authored-by: Lukasz Gornicki <[email protected]>
applied suggstion from: asyncapi#2276 (comment) Co-authored-by: Lukasz Gornicki <[email protected]>
applied suggestion from: asyncapi#2276 (comment) Co-authored-by: Lukasz Gornicki <[email protected]>
applied suggestion from: asyncapi#2276 (comment) Co-authored-by: Lukasz Gornicki <[email protected]>
applied suggestion from: asyncapi#2276 (comment) Co-authored-by: Lukasz Gornicki <[email protected]>
applied suggestion from: asyncapi#2276 (comment) Co-authored-by: Lukasz Gornicki <[email protected]>
applied suggestion from: asyncapi#2276 (comment) Co-authored-by: Lukasz Gornicki <[email protected]>
applied suggestion from: https://github.com/asyncapi/website/pull/2276/files#r1386867168 Co-authored-by: Lukasz Gornicki <[email protected]>
derberg
previously approved these changes
Nov 9, 2023
quetzalliwrites
approved these changes
Nov 10, 2023
|
/rtm |
AnimeshKumar923
deleted the
adapt-studio-document-validation-tutorial-for-v3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
studio document validationin the next-major-spec branch.Related issue(s)
Fixes #1862