-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update frontpage animation for v3 #1975
refactor: update frontpage animation for v3 #1975
Conversation
Signed-off-by: Afzal Ansari <[email protected]>
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thanks! the document is accurate and looks good, but I'm not sure about the "docs preview" on the right probably and maybe that is enough for such a fancy animation 🤔 @jonaslagoni |
@derberg as mentioned in the issue, the docs changes, technically cant really be done until asyncapi/asyncapi-react#733 is solved. Unless we want a divergent in what is displayed. Not sure how it's best to be handled i.e. why it's up to you codeowners how its best achieved 😄 |
@jonaslagoni yeah, react. I don't want to wait for it. current animation is basic, and the only visual "issue" is |
Signed-off-by: Afzal Ansari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afzal442 I just noticed you made a push to fix final stuff. Please next time mention folks, or rerequest review as when you just push code, notifications are not triggered and we do not know you followed up
Thanks @afzal442 a lot /rtm |
Related issue(s)
Closes: #1853
After: https://deploy-preview-1975--shimmering-choux-eb0798.netlify.app/