Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update frontpage animation for v3 #1975

Merged

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Jul 20, 2023

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 9f57a50
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/64c2969d962143000850e6a3
😎 Deploy Preview https://deploy-preview-1975--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@derberg
Copy link
Member

derberg commented Jul 25, 2023

thanks!

the document is accurate and looks good, but I'm not sure about the "docs preview" on the right
Screenshot 2023-07-25 at 12 41 19

probably SUB should be renamed to RECEIVES 🤔

and maybe that is enough for such a fancy animation 🤔 @jonaslagoni

@jonaslagoni
Copy link
Member

@derberg as mentioned in the issue, the docs changes, technically cant really be done until asyncapi/asyncapi-react#733 is solved.

Unless we want a divergent in what is displayed.

Not sure how it's best to be handled i.e. why it's up to you codeowners how its best achieved 😄

components/DemoAnimation.js Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Jul 26, 2023

@jonaslagoni yeah, react. I don't want to wait for it.

current animation is basic, and the only visual "issue" is SUB, so please @afzal442 just change to RECEIVES so we have basic done. Of something more changes in future, then we will have separate PR for that

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afzal442 I just noticed you made a push to fix final stuff. Please next time mention folks, or rerequest review as when you just push code, notifications are not triggered and we do not know you followed up

@derberg
Copy link
Member

derberg commented Oct 25, 2023

Thanks @afzal442 a lot

/rtm

@asyncapi-bot asyncapi-bot merged commit 5793f4c into asyncapi:next-major-spec Oct 25, 2023
1 check passed
@afzal442 afzal442 deleted the refactor-asyncapi-animn-v3 branch October 25, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants