Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated frontpage animation for v3 #1888

Closed
wants to merge 2 commits into from
Closed

refactor: updated frontpage animation for v3 #1888

wants to merge 2 commits into from

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Jul 3, 2023

Related issue(s)

Closes: #1853

After:
async1

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2f17e5b
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64b8282319bd4700076bcb20
😎 Deploy Preview https://deploy-preview-1888--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 44
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1888--asyncapi-website.netlify.app/

@afzal442 afzal442 changed the title refactor: Updated frontpage animation for v3 refactor: updated frontpage animation for v3 Jul 3, 2023
@derberg
Copy link
Member

derberg commented Jul 19, 2023

@afzal442 you need to do some adjustment. The related issue specified that you need to create a branch out of next-major-spec and open PR against next-major-spec, as this needs to be done on feature branch, not master

@afzal442
Copy link
Contributor Author

Yes I see. I got that when I was taking snap after making changes. thanks for your pointers. 😄

Copy link
Member

derberg commented Jul 19, 2023

will you try to update this PR or create new one? if new one, do not forget to close this one

@afzal442 afzal442 requested a review from Mayaleeeee as a code owner July 19, 2023 18:14
@afzal442
Copy link
Contributor Author

hi @derberg sure I will do that. thanks

@afzal442 afzal442 closed this by deleting the head repository Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: Adapt frontpage animation for v3
2 participants