Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added confirmation to create new file #977

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

ashmit-coder
Copy link
Contributor

Description

  • The feature creates a modal prompt before creating a new file to prevent user from loosing his data

  • Old Behaviour

AsyncAPI-Studio.mp4
  • Current Behaviour
AsyncAPI-Studio.1.mp4

Related issue(s)

Resolves: #724

Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: e3ff90c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit e3ff90c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/65de07a4ef41cb0007276a8f
😎 Deploy Preview https://deploy-preview-977--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit e3ff90c
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/65de07a4cd88690008f677c6
😎 Deploy Preview https://deploy-preview-977--modest-rosalind-098b67.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ashmit-coder
Copy link
Contributor Author

Hey @Amzani Please check the Updates. :)

@ashmit-coder ashmit-coder requested a review from Amzani February 26, 2024 16:08
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amzani
Copy link
Collaborator

Amzani commented Feb 27, 2024

/au

@Amzani
Copy link
Collaborator

Amzani commented Feb 27, 2024

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @Amzani! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ashmit-coder
Copy link
Contributor Author

Hey @Amzani I guess i did something wrong but the PR wont merge. Appologies from my side.

@ashmit-coder
Copy link
Contributor Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 0a913c8 into asyncapi:master Feb 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Async API Studio should notify you that changes will be lost when selecting "New File"
3 participants