Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add client and server icon #792

Merged
merged 4 commits into from
Sep 18, 2023
Merged

feat: add client and server icon #792

merged 4 commits into from
Sep 18, 2023

Conversation

princerajpoot20
Copy link
Member

Resolves #791 Added the missing Client and Server Icon and rename ProtocolBadge to ServiceInfoBadge

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 508ccad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 16, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 508ccad
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/65081a995e3f57000851b227
😎 Deploy Preview https://deploy-preview-792--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 16, 2023 •
edited
Loading

❌ Deploy Preview for modest-rosalind-098b67 failed.

Name Link
🔨 Latest commit 508ccad
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/65081a9971a1350008c8fe36

fmvilas
fmvilas requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request 👍

apps/design-system/src/components/ServiceInfoBadge.stories.tsx Outdated
@@ -16,6 +16,18 @@ export const HTTP = {
}
}

export const Server = {
args: {
protocol: 'server'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably rename protocol to info or something similar since it's not a Protocol Badge anymore. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info would be a good choice, or we could use serviceName or serviceInfo, which would be a bit clearer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave it up to you :) I'm fine with anything except serviceName because it's not the name of the service.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fmvilas
fmvilas approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 18, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 946d2c0 into asyncapi:master Sep 18, 2023
16 of 20 checks passed
@Amzani Amzani mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@boyney123 boyney123 Awaiting requested review from boyney123

@mcturco mcturco Awaiting requested review from mcturco

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@KhudaDad414 KhudaDad414 Awaiting requested review from KhudaDad414 KhudaDad414 is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Client and Server Icon.
3 participants
@princerajpoot20 @fmvilas @asyncapi-bot