Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setup a new next app on studio next #738

Merged
merged 12 commits into from
Aug 29, 2023
Merged

feat: setup a new next app on studio next #738

merged 12 commits into from
Aug 29, 2023

Conversation

Shurtu-gal
Copy link
Collaborator

Description

  • Setup a new next app in studio-next folder

Related issue(s)

Resolves #727

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6161b6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited
Loading

✅ Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 6161b6f
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64ed8c3a6c1c93000816d2ff
😎 Deploy Preview https://deploy-preview-738--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 6161b6f
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64ed8c3a5e597e00092f8ec7
😎 Deploy Preview https://deploy-preview-738--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shurtu-gal Shurtu-gal marked this pull request as ready for review July 13, 2023 07:43
@fmvilas
Copy link
Member

fmvilas commented Jul 13, 2023

@Shurtu-gal linting is failing. Can you have a look?

@Shurtu-gal
Copy link
Collaborator Author

@fmvilas Done it!

fmvilas
fmvilas previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Shurtu-gal
Copy link
Collaborator Author

Sure, I will make the changes.

@Shurtu-gal
Copy link
Collaborator Author

@KhudaDad414 All changes are done.

@Shurtu-gal Shurtu-gal requested a review from KhudaDad414 July 26, 2023 17:16
KhudaDad414
KhudaDad414 previously approved these changes Jul 27, 2023
View reviewed changes
@Amzani
Copy link
Collaborator

Amzani commented Aug 3, 2023

@KhudaDad414 @smoya do you have access to Netlify of studio ? we need add a new domain https://studio-next.asyncapi.com/ that point to right publish directory (cc @Shurtu-gal )

@KhudaDad414
Copy link
Member

@Amzani, @derberg might be able to help here.

@smoya
Copy link
Member

smoya commented Aug 3, 2023

@KhudaDad414 @smoya do you have access to Netlify of studio ? we need add a new domain https://studio-next.asyncapi.com/ that point to right publish directory (cc @Shurtu-gal )

Not me. Btw, not sure if Netlify manages the DNS for Studio. I think its all in a domain provider and most probably managed by Linux Foundation. Anyway, @derberg @fmvilas can answer.

Amzani
Amzani requested changes Aug 3, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
KhudaDad414
KhudaDad414 previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Shurtu-gal
Copy link
Collaborator Author

Hey, @KhudaDad414 Can this be merged as I have to work on further things #762?

@Shurtu-gal
Copy link
Collaborator Author

/rtm

@Shurtu-gal Shurtu-gal requested a review from KhudaDad414 August 14, 2023 06:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member

fmvilas commented Aug 29, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 283e568 into asyncapi:master Aug 29, 2023
@Shurtu-gal Shurtu-gal deleted the feat/studio-next branch September 15, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@boyney123 boyney123 Awaiting requested review from boyney123

@mcturco mcturco Awaiting requested review from mcturco

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@Amzani Amzani Awaiting requested review from Amzani Amzani is a code owner

@KhudaDad414 KhudaDad414 Awaiting requested review from KhudaDad414 KhudaDad414 is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup NextJS app
6 participants
@Shurtu-gal @fmvilas @Amzani @KhudaDad414 @smoya @asyncapi-bot