-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing arg to installer layer #714
Conversation
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the fix. We totally overlooked that 🙏 |
/rtm |
Hello, @fmvilas! 👋🏼 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/au |
/rtm |
🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
The PR https://github.com/asyncapi/studio/pull/688/files changed the Dockerfile so that the
BASE_URL_PLACEHOLDER
arg was missing in theinstaller
layer. Note that args need to specified for every layer.Related issue(s)
Closes #550