Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing arg to installer layer #714

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Jul 4, 2023

Description

The PR https://github.com/asyncapi/studio/pull/688/files changed the Dockerfile so that the BASE_URL_PLACEHOLDER arg was missing in the installer layer. Note that args need to specified for every layer.

Related issue(s)

Closes #550

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit b8f38a3
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64a487b996fc79000811d998
😎 Deploy Preview https://deploy-preview-714--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit b8f38a3
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64a487b9ba0437000816ae91
😎 Deploy Preview https://deploy-preview-714--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fgreinacher fgreinacher marked this pull request as ready for review July 4, 2023 08:54
@fmvilas
Copy link
Member

fmvilas commented Jul 4, 2023

Thanks for the fix. We totally overlooked that 🙏

@fmvilas
Copy link
Member

fmvilas commented Jul 4, 2023

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @fmvilas! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fgreinacher
Copy link
Contributor Author

/au

@fmvilas
Copy link
Member

fmvilas commented Jul 4, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 39d1b2e into asyncapi:master Jul 4, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fgreinacher fgreinacher deleted the fix/missing-arg branch July 5, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BASE_URL issue
3 participants