feat: add share functionality #618
Conversation
Shurtu-gal
requested review from
fmvilas,
boyney123,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
I have concerns about building such long URLs. They may not work in all browsers. Not even in all the modern ones.
I just found the table below in the following Stack Overflow question: https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers.
Browser Address bar document.location
or anchor tag
------------------------------------------
Chrome 32779 >64k
Android 8192 >64k
Firefox >64k >64k
Safari >64k >64k
IE11 2047 5120
Edge 16 2047 10240
Can I ask you what's your use case? Why do you want to copy and share a URL but you don't want to copy and share the document itself? Honest question, just want to understand as I'm working on drafting the future of Studio and want to understand the needs better.
|
@fmvilas This was done as per this comment #463 (comment) |
|
If we don't want such long urls then we would have to use a storage. Either on our side or in their own Drives, dropboxes etc. |
Yes, that's in my plans for the next Studio version: https://github.com/orgs/asyncapi/projects/16/views/1. Look, what I'd do is to add this feature knowing that it may fail in certain cases. I think we can live with that. Some people may experience issues but others (the majority?) will not so let's not block something that may be useful for them. Are you ok with that @magicmatatjahu @derberg? |
|
I use this feature in mermaid all the time https://mermaid.live/ |
|
@Shurtu-gal let's merge this PR. can you resolve the conflicts please? |
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@KhudaDad414 done |
|
/rtm |
|
@jonaslagoni SonarCloud is complaining about the changes for #796 here. this is weird. 🤔 |
|
Sonar cloud in a nut shell 🤷 |
|
/rtm |
😆 |
|
@KhudaDad414 I would just ignore sonar and force-push it manually. |
|
Agree with @jonaslagoni we will anyway have duplicated code during the transition period to V3. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
Description
Related issue(s)
Fixes #463
Blocked by #807