Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DropdownMenu #1108

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Jun 3, 2024

Description

  • Refactor the dropdown menu to make it more customizable for its users.
    Reasoning: Tried to implement a multi-select dropdown menu, but the current implementation is too rigid to allow such an improvement.

  • Add the utils package: The utils package currently contains only one method: class-names or in short cn. It is going to be used in at least 3 packages.
    Reasoning

blocked by asyncapi/.github#300

Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: c719e47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit c719e47
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/6668344018db2200086657be
😎 Deploy Preview https://deploy-preview-1108--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit c719e47
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/666834400f036f0008e5b4e5
😎 Deploy Preview https://deploy-preview-1108--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit c719e47
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/66683440fc0e8b0008b551b1
😎 Deploy Preview https://deploy-preview-1108--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

princerajpoot20
princerajpoot20 previously approved these changes Jun 4, 2024
Copy link
Member

@princerajpoot20 princerajpoot20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Amzani
Amzani previously approved these changes Jun 4, 2024
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414 KhudaDad414 dismissed stale reviews from Amzani and princerajpoot20 via 24e20a9 June 10, 2024 16:21
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Jun 11, 2024
Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit a428b15 into asyncapi:master Jun 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants