Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add og tags to studio-next #1106

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Conversation

helios2003
Copy link
Contributor

Description
Adds static open graph tags to the studio-next application.

Screenshots
For Twitter:
Screenshot 2024-05-28 234008

For Whatsapp
Screenshot 2024-05-28 234650

Network Tab
Screenshot 2024-05-28 234752

Known limitation(s)
The AsyncAPI image does not get rendered when sharing the link on Slack but works on all other social media platforms.

Related issue(s)

Since #224 has been chosen for this year's GSoC I will add incremental improvements and bring it closer to the actual project which includes making the og-tags as well the og-image dynamic.

Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: 4b3125c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented May 31, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit 4b3125c
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/6666e5babc97c9000831db84
😎 Deploy Preview https://deploy-preview-1106--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 4b3125c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/6666e5ba4f17dd0008c01e12
😎 Deploy Preview https://deploy-preview-1106--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 31, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 4b3125c
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/6666e5ba3604db000832119e
😎 Deploy Preview https://deploy-preview-1106--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KhudaDad414
Copy link
Member

@helios2003 there is some effort to generate the graph from the content of the AsyncAPI file here: #224

@KhudaDad414
Copy link
Member

You can close the issue, since it causes conflicts with the work being done over there.

@helios2003
Copy link
Contributor Author

helios2003 commented Jun 5, 2024

@helios2003 there is some effort to generate the graph from the content of the AsyncAPI file here: #224

This is a GSoC issue and this PR is a part of the issue.

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also include one small change so the release pipeline gets unblocked here?
can you remove this changeset ?

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414
Copy link
Member

@helios2003 feel free to merge when ready.

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit f5676ec into asyncapi:master Jun 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants