-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add og tags to studio-next #1106
Conversation
|
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@helios2003 there is some effort to generate the graph from the content of the AsyncAPI file here: #224 |
You can close the issue, since it causes conflicts with the work being done over there. |
This is a GSoC issue and this PR is a part of the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also include one small change so the release pipeline gets unblocked here?
can you remove this changeset ?
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@helios2003 feel free to merge when ready. |
/rtm |
Description
Adds static open graph tags to the studio-next application.
Screenshots
For Twitter:
For Whatsapp
Network Tab
Known limitation(s)
The AsyncAPI image does not get rendered when sharing the link on Slack but works on all other social media platforms.
Related issue(s)
Since #224 has been chosen for this year's GSoC I will add incremental improvements and bring it closer to the actual project which includes making the
og-tags
as well theog-image
dynamic.