Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable navigation for v3 #796

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Oct 3, 2023

Description
This PR enables navigation for v3 and updates the underlying document to use the new parser API instead of the old document.

This does not:

  • Update the HTML template and documentation as I will do that in another PR, so it still uses the old API.
  • Update the Visualizer, so it still uses the old API.

Related issue(s)
Fixes #793

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: a606ffc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit a606ffc
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/651c2ab47511770007f36137
😎 Deploy Preview https://deploy-preview-796--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit a606ffc
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/651c2ab45e841f00089e1a91
😎 Deploy Preview https://deploy-preview-796--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @jonaslagoni! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@jonaslagoni
Copy link
Member Author

/au

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 4284264 into asyncapi:master Oct 3, 2023
20 checks passed
@jonaslagoni jonaslagoni deleted the enable_navigation branch October 5, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert code to use new parser API document
3 participants