fix: update some examples according to v3 #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
requested review from
fmvilas,
derberg,
dalelane,
char0n and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
dalelane
approved these changes
Sep 17, 2023
|
/rtm |
asyncapi-bot
merged commit abfae49
into
asyncapi:next-major-spec
31 of 32 checks passed
|
🎉 This PR is included in version 3.0.0-next-major-spec.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one example I found was out of date.
As a side note, It would be nice if all examples within the spec (not the ones in examples dir) are tested by CI. For that, we would need to include full examples (with all the required fields, such as
info, etc). #957 might be the issue to push for.