Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update readme, add sponsors section, review requested #886

Merged
merged 9 commits into from
Dec 19, 2022
Merged

docs: update readme, add sponsors section, review requested #886

merged 9 commits into from
Dec 19, 2022

Conversation

AnimeshKumar923
Copy link
Contributor

@AnimeshKumar923 AnimeshKumar923 commented Dec 14, 2022 •
edited
Loading

title: "sponsors section add in README.md"

closes issue #883

Related issue(s):
bump.sh logo not clearly visible, help required @derberg

@AnimeshKumar923
add ibm.png logo, (platinum tier sponsor)
91eeea0 
add ibm logo as they are in platinum tier sponsor
@AnimeshKumar923
add postman to platinum-tier
e1bba40
@AnimeshKumar923
update README.md
dfdbb95 
add platinum-tier
@AnimeshKumar923
add redhat as gold sponsor
1eb85b4 
redhat logo png add
@AnimeshKumar923
add bump.sh as silver sponsor.
108dcba 
add bump.sh logo.
@AnimeshKumar923
add gold and silver sponsors
29dd36a 
- upload logos
- update gold and silver sponsors
- bump.sh logo is not clearly visible, help required...
github-actions[bot]
github-actions bot reviewed Dec 14, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@AnimeshKumar923 AnimeshKumar923 changed the title update readme, add sponsors section, review requested docs: update readme, add sponsors section, review requested Dec 14, 2022
@AnimeshKumar923
Copy link
Contributor Author

@derberg bump logo not clearly visible, help is required

@sambhavgupta0705
Copy link
Member

you can also share a preview image of this if its possible

@AnimeshKumar923
Copy link
Contributor Author

you can also share a preview image of this if its possible

Okay, sharing it in few moments...

@AnimeshKumar923
Copy link
Contributor Author

you can also share a preview image of this if its possible

Here it is:

sponsors-section-preview

@derberg
Copy link
Member

derberg commented Dec 15, 2022

yeah, the dark mode 😞 I think there is some solution, but don't remember what it requires. Looks like officially recommended way is https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://user-images.githubusercontent.com/25423296/163456776-7f95b81a-f1ed-45f7-b7ab-8fa810d529fa.png">
  <source media="(prefers-color-scheme: light)" srcset="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
  <img alt="Shows an illustrated sun in light mode and a moon with stars in dark mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

in light mode it is ok

Screenshot 2022-12-15 at 10 11 14

Just please remove logos of sponsors from top of the readme

@sambhavgupta0705
Copy link
Member

just a suggestion that we can bump.sh logo on white background just as redhat logo ,that will work fine in dark mode also
@AnimeshKumar923

@AnimeshKumar923
Copy link
Contributor Author

just a suggestion that we can bump.sh logo on white background just as redhat logo ,that will work fine in dark mode also
@AnimeshKumar923

I will try that and update about it.

@AnimeshKumar923
add bump.sh logo with white background
cc44408
@AnimeshKumar923
Update README.md
bfeea2b 
- add bump.sh logo with white background for better visibility in dark-mode user as well as light-mode user.
@AnimeshKumar923
Update README.md, sponsor removal
ec229cc 
- remove logos of sponsors commenting out
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AnimeshKumar923
Copy link
Contributor Author

@derberg please review the changes

@derberg
Copy link
Member

derberg commented Dec 19, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 95643a7 into asyncapi:master Dec 19, 2022
@AnimeshKumar923
Copy link
Contributor Author

Feels good when the PR you're working on gets merged. Thank you @derberg

This was referenced Dec 19, 2022
Closed
Closed
@derberg Volta.net
Copy link
Member

derberg commented Dec 19, 2022

thanks @AnimeshKumar923 for contributing the change 🙇‍♂️

@AnimeshKumar923
Copy link
Contributor Author

thanks @AnimeshKumar923 for contributing the change 🙇‍♂️

@derberg it's my pleasure sir, I'm new to open source so looking forward to more contributions.🙇🚀

@derberg Volta.net
Copy link
Member

derberg commented Dec 20, 2022

Congrats on getting your stuff merged at AsyncAPI.
Feel free to join our Slack https://asyncapi.com/slack-invite

we also list good first issues in this dashboard -> https://www.asyncapi.com/community/dashboard

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Dec 4, 2023
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@smoya
Copy link
Member

smoya commented Feb 8, 2024

@all-contributors please add @AnimeshKumar923 for content,doc,maintenance

@allcontributors allcontributors bot mentioned this pull request Feb 8, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@smoya

I've put up a pull request to add @AnimeshKumar923! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AnimeshKumar923 @sambhavgupta0705 @derberg @asyncapi-bot @smoya @fmvilas