-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: let channels be identified by ID. Address is now moved into a new field #719
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@@ -20,13 +20,14 @@ These files can then be used to create utilities, such as documentation, integra | |||
The file(s) MUST describe the operations an [application](#definitionsApplication) accepts. For instance, consider the following AsyncAPI definition snippet: | |||
|
|||
```yaml | |||
user/signedup: | |||
userSignedUp: | |||
address: "user/signedup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we want to keep calling this path
instead of address
? I would love to know others opinion. I'm fine with address
anyway.
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Closing in favour of #827 |
This PR allows channels to be identified by an ID rather than by their address. Instead, the address has now been moved into a new field called
address
.This is a breaking change so it should be considered as a candidate for
v3.0.0
.Related issue(s):
See #663 for knowing about the reason behind this RFC.
CC @char0n @magicmatatjahu @derberg